feat: collect to list (non-windowed) (primitive/strings/booleans) #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
jordanrfrazier
commented
Jul 31, 2023
bjchambers
reviewed
Jul 31, 2023
bjchambers
reviewed
Jul 31, 2023
crates/sparrow-instructions/src/evaluators/list/collect_primitive.rs
Outdated
Show resolved
Hide resolved
crates/sparrow-instructions/src/evaluators/list/collect_string.rs
Outdated
Show resolved
Hide resolved
jordanrfrazier
force-pushed
the
feat/col-list-function
branch
from
941e2d1
to
5622d0b
Compare
bjchambers
reviewed
Jul 31, 2023
crates/sparrow-instructions/src/evaluators/list/collect_string.rs
Outdated
Show resolved
Hide resolved
bjchambers
approved these changes
Jul 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
collectfunction for non-windowed, primitive/string/boolean types.This doesn't support
LargeUtf8because the other string aggregations that use thecreate_typed_evaluatormacro don't support generic offset size, so that will come in a follow up.